25167 add feature flags service enable won emails #1659
Conversation
kzdev420
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag,
flutistar and
EPortman
as code owners
|
Once this is ready to be merged the emailer needs to install the latest API changes. If simply running
|
There was a problem hiding this comment.
The purpose of the Feature Flag is to:
- if True, send out the new emails
- if False, send out the old emails
This needs to apply for all "way of navigation" emails -- NEW and CHG/CNV.
I think I don't see both the old and new code, conditional on the FF, in this PR.
Update: Kevin walked me through this. In a nutshell, some duplicate code was removed as it is now directly available in Namex API.
I think this is fine.
|
@kzdev420 Are there new linting and testing issues?
|
|
| @@ -81,3 +81,6 @@ MRAS_SVC_API_KEY= | |||
|
|
|||
| # Local development only | |||
| DISABLE_NAMEREQUEST_SOLR_UPDATES=1 | |||
|
|
|||
| # launchdarkly | |||
| NAMEX_LD_SDK_ID=sdk-075200eb-4ff7-4e0e-872a-848585d3d460 | |||
There was a problem hiding this comment.
@kzdev420
I bet this key has to be imported in api/config.py.
Issue #, if available: #25167
Description of changes:
Add Feature Flags service.
Use the enable way of navigation emails FF
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).